XML Author Eclipse XML Diff

[josephw]

Hi,
we are currently working on the XML Compare feature within the Oxygen Eclipse Plugin.
We are facing some issues and differences to the Oxygen Author Standalone Version.
It seems that the CSS Styles filters are not loaded. We also saw that conrefed content is not visualized inside the Topic.

Is there a possibility to get the defined framework-settings loaded in the Compare View inside Eclipse? And conrefs included in topics?

Thanks,
Joseph

[Radu]

Hi Joseph,

We managed to reproduce the problem with conrefs/conkeyrefs/keyrefs not properly displayed in the comparison panel. We have an internal issue and we'll probably fix this in Oxygen 25 (September this year). If you want to test this sooner you can drop us an email (support@oxygenxml.com) and we can try to make available an Oxygen 25 beta kit for tests.

About this remark:

It seems that the CSS Styles filters are not loaded.

Can you give us more details? Do you mean you have your own custom implementation of the "StylesFilter" Java API? Did you implement it in a framework configuration or via a plugin extension? Does your "StylesFilter" implementation also extend the "AuthorExtensionStateListener" API?

Regards,
Radu

[josephw]

Hi Radu,

yes, we have a custom implementation of the StylesFilter. It is defined in a framework configuration.
Originally our StylesFilter hasn't implemented the AuthorExtensionStateListener, but with it implemented, there was no difference. The activated function doesn't get called in compare editor, but is in normal Oxygen editor.

I'll try to move our implementation in a plugin extension for a test.

Regards,
Joseph

[Radu]

Hi Joseph,

Right, thanks for the details. In Oxygen 25 we'll have this case in which the StylesFilter implements AuthorExtensionStateListener and no longer receives activated() fixed as well.

Regards,
Radu

[josephw]

Hi Radu,

I've now tested to get the StylesFilter from StylesFilterContributor and also tested to get it from ExtensionsBundle (createAuthorStylesFilter), but both is not working for me in Compare Editor.
When opening a topic in Oxygen Editor everything is working fine.

Regards,
Joseph

[Radu]

Hi Joseph,

I checked our current code (after we made some changes on our side based on your post) with a very simple StylesFilter implementation:

Code: Select all

 new StylesFilter() {
          @Override
          public String getDescription() {
            return null;
          }
          
          @Override
          public Styles filter(Styles styles, AuthorNode authorNode) {
            styles = styles.clone();
            styles.setProperty(Styles.KEY_FOREGROUND_COLOR, Color.COLOR_DARK_YELLOW);
            return styles;
          }
        };
      }

and it should work when set either in the extensions bundle or via the plugin extension mechanism both for XML files opened in the editor and for XML files open in the comparison tool.
As I previously said if you want to test this sooner (and maybe you should double check everything with your implementation) you can drop us an email (support@oxygenxml.com) and we can try to make available an Oxygen 25 beta kit for tests.

Regards,
Radu

[tavy]

Hello Joseph,

I just want to let you know that we released Oxygen version 25.0 The problem with conrefs/conkeyrefs/keyrefs not properly displayed in the comparison panel was solved in the new version: https://www.oxygenxml.com/xml_editor/do ... os=Eclipse

Best Regards,
Octavian

[josephw]

Hi Radu,

since we can now load conrefs in XML Compare, we faced another issue.
Clicking on the open link icon, the referenced file is opened with windows specified Tool and is not opened in internal Oxygen Editor.
Can you reproduce this behavior, or do you have an idea what we can do to open referenced dita file in internal editor?

Best Regards,
Joseph

[Radu]

Hi Joseph,

Yes, I can reproduce the problem, I added this internal issue to fix this as well:

EXM-51987 Eclipse Compare Files - Clicking Links does not open topics in Eclipse workbench

Is this an urgent problem for you? We plan to release Oxygen 25.1 in March next year.

Regards,
Radu

[josephw]

Hi Radu,

this is not urgent for us, we can wait for fixed version.

Best Regards,
Joseph

[Radu]

Hi Joseph,
As an update, we released Oxygen 25.1 and it should have a fix for this problem you reported.
Regards,
Radu